Feat: Highlight cards with important labels#7218
Conversation
Koc
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
Koc
force-pushed
the
feature/add-important-flag
branch
7 times, most recently
from
a18fdf4 to
d8e5c8f
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/add-important-flag
branch
from
d8e5c8f to
bbe72b9
Compare
|
rebased, resolved conflicts 🤕 |
| this.$store.dispatch('updateLabelFromCurrentBoard', this.editingLabel) | ||
| const payload = { | ||
| ...this.editingLabel, | ||
| customSettings: { ...this.editingLabel.customSettings }, |
There was a problem hiding this comment.
This line looks redundant. this.editingLabel should contain customSettings already.
| this.$store.dispatch('addLabelToCurrentBoard', this.addLabelObj) | ||
| const payload = { | ||
| ...this.addLabelObj, | ||
| customSettings: { ...this.addLabelObj.customSettings }, |
There was a problem hiding this comment.
customSettings was already initialized and assigned to addLabelObj at line 200. So, line 206 looks redundant.
|
@marcoambrosini I have tested and it works but we need your advice.
|
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Hi @Koc,
Thanks a lot for your contribution and for taking the time to put this together! 🙏
I’m really sorry, but I’ll have to reject this change for now. Adding an “important” toggle switch for every tag feels a bit redundant since the same effect can be achieved by simply adding another tag. Each new setting adds complexity to the user interface, and we want to be careful not to introduce friction unless the benefit is clear and significant.
Before adding new features or settings, it’s good to ask:
• What value does this bring to the user?
• Could it be done another way without adding extra complexity?
In this case, I don’t think it’s the best tradeoff.
For future contributions, could you please open an issue first so we can discuss ideas before development work starts? That way, we can make sure the effort goes in the right direction.
Thanks again for the initiative and your willingness to improve the project. It’s much appreciated!
3 participants
Summary
This PR adds "Important" toggle to the Labels. Carts with Labels marked as important are highlighted on a board.
Preview
TODO
Checklist